diff options
| author | Yury Norov <yury.norov@gmail.com> | 2022-02-10 14:48:56 -0800 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2022-02-15 14:38:57 +0000 |
| commit | 95ed57c73bbcffa02cbb1d61c19484c2ec6de094 (patch) | |
| tree | 868ab4d1a7d99ade05dc3729f5dc705d10387d87 /drivers/perf/xgene_pmu.c | |
| parent | 602c873eb52e5717057eb0971258c8eb7440c4a5 (diff) | |
| download | lwn-95ed57c73bbcffa02cbb1d61c19484c2ec6de094.tar.gz lwn-95ed57c73bbcffa02cbb1d61c19484c2ec6de094.zip | |
perf: replace bitmap_weight with bitmap_empty where appropriate
In some places, drivers/perf code calls bitmap_weight() to check if any
bit of a given bitmap is set. It's better to use bitmap_empty() in that
case because bitmap_empty() stops traversing the bitmap as soon as it
finds first set bit, while bitmap_weight() counts all bits unconditionally.
Signed-off-by: Yury Norov <yury.norov@gmail.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20220210224933.379149-13-yury.norov@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/perf/xgene_pmu.c')
| -rw-r--r-- | drivers/perf/xgene_pmu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index 5283608dc055..0c32dffc7ede 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@ -867,7 +867,7 @@ static void xgene_perf_pmu_enable(struct pmu *pmu) { struct xgene_pmu_dev *pmu_dev = to_pmu_dev(pmu); struct xgene_pmu *xgene_pmu = pmu_dev->parent; - int enabled = bitmap_weight(pmu_dev->cntr_assign_mask, + bool enabled = !bitmap_empty(pmu_dev->cntr_assign_mask, pmu_dev->max_counters); if (!enabled) |