diff options
| author | David Daney <david.daney@cavium.com> | 2015-08-19 13:17:47 -0700 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2015-08-25 11:29:56 -0500 |
| commit | 3a496b00b6f90c41bd21a410871dfc97d4f3c7ab (patch) | |
| tree | b633747f5c4608e1f7122be4f96524a86bd2a25a /drivers/of/address.c | |
| parent | 068627a5978a885b33f0f49da81860ce78c3ac6f (diff) | |
| download | lwn-3a496b00b6f90c41bd21a410871dfc97d4f3c7ab.tar.gz lwn-3a496b00b6f90c41bd21a410871dfc97d4f3c7ab.zip | |
of/address: Don't loop forever in of_find_matching_node_by_address().
If the internal call to of_address_to_resource() fails, we end up
looping forever in of_find_matching_node_by_address(). This can be
caused by a defective device tree, or calling with an incorrect
matches argument.
Fix by calling of_find_matching_node() unconditionally at the end of
the loop.
Signed-off-by: David Daney <david.daney@cavium.com>
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of/address.c')
| -rw-r--r-- | drivers/of/address.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c index 8bfda6ade2c0..384574c3987c 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -845,10 +845,10 @@ struct device_node *of_find_matching_node_by_address(struct device_node *from, struct resource res; while (dn) { - if (of_address_to_resource(dn, 0, &res)) - continue; - if (res.start == base_address) + if (!of_address_to_resource(dn, 0, &res) && + res.start == base_address) return dn; + dn = of_find_matching_node(dn, matches); } |