diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2024-02-01 14:46:00 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-02-03 12:50:45 +0000 |
| commit | f2ec98566775dd4341ec1dcf93aa5859c60de826 (patch) | |
| tree | b2efdf59fcfa32965579f6fb44fb59996a0e3c38 /drivers/net | |
| parent | 0eb1ec426cfcdac021c3f5c0c8fc1127047050e5 (diff) | |
| download | lwn-f2ec98566775dd4341ec1dcf93aa5859c60de826.tar.gz lwn-f2ec98566775dd4341ec1dcf93aa5859c60de826.zip | |
net: phy: qcom: qca808x: fix logic error in LED brightness set
In switching to using phy_modify_mmd and a more short version of the
LED ON/OFF condition in later revision, it was made a logic error where
value ? QCA808X_LED_FORCE_ON : QCA808X_LED_FORCE_OFF is always true as
value is always OR with QCA808X_LED_FORCE_EN due to missing ()
resulting in the testing condition being QCA808X_LED_FORCE_EN | value.
Add the () to apply the correct condition and restore correct
functionality of the brightness ON/OFF.
Fixes: 7196062b64ee ("net: phy: at803x: add LED support for qca808x")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/phy/qcom/qca808x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c index 0f549027d899..00db4b274264 100644 --- a/drivers/net/phy/qcom/qca808x.c +++ b/drivers/net/phy/qcom/qca808x.c @@ -820,8 +820,8 @@ static int qca808x_led_brightness_set(struct phy_device *phydev, return phy_modify_mmd(phydev, MDIO_MMD_AN, reg, QCA808X_LED_FORCE_EN | QCA808X_LED_FORCE_MODE_MASK, - QCA808X_LED_FORCE_EN | value ? QCA808X_LED_FORCE_ON : - QCA808X_LED_FORCE_OFF); + QCA808X_LED_FORCE_EN | (value ? QCA808X_LED_FORCE_ON : + QCA808X_LED_FORCE_OFF)); } static int qca808x_led_blink_set(struct phy_device *phydev, u8 index, |