diff options
| author | Tom Rix <trix@redhat.com> | 2022-04-19 10:06:25 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-04-22 12:43:35 +0100 |
| commit | 0844d36f771d3fe3c418df7569396a9a58feab85 (patch) | |
| tree | 673e6d350ed1bb7bacf0b6b31bcd5cb7345d3ec8 /drivers/net/usb/sr9800.h | |
| parent | 6f37c9f9dfbf9a9645ec5ea2d9370b0fd3e9081e (diff) | |
| download | lwn-0844d36f771d3fe3c418df7569396a9a58feab85.tar.gz lwn-0844d36f771d3fe3c418df7569396a9a58feab85.zip | |
USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
Smatch reports this issue
sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?
Global variables should not be defined in header files.
This only works because sr9800.h in only included by sr9800.c
Change the storage-class specifier to static.
And since it does not change add type qualifier const.
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/sr9800.h')
| -rw-r--r-- | drivers/net/usb/sr9800.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/sr9800.h b/drivers/net/usb/sr9800.h index 18f670251275..952e6f7c0321 100644 --- a/drivers/net/usb/sr9800.h +++ b/drivers/net/usb/sr9800.h @@ -163,7 +163,7 @@ #define SR9800_MAX_BULKIN_24K 6 #define SR9800_MAX_BULKIN_32K 7 -struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = { +static const struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = { /* 2k */ {2048, 0x8000, 0x8001}, /* 4k */ |