diff options
author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2021-11-23 12:40:00 -0800 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2021-11-25 07:39:31 -0800 |
commit | eaeace60778e524a2820d0c0ad60bf80289e292c (patch) | |
tree | 074fa0847a096d156bd8079f9a882243a204be2b /drivers/net/mdio | |
parent | fef30d6371b0ad71c200a7c360a219b74b3fe07c (diff) | |
download | lwn-eaeace60778e524a2820d0c0ad60bf80289e292c.tar.gz lwn-eaeace60778e524a2820d0c0ad60bf80289e292c.zip |
igb: fix netpoll exit with traffic
Oleksandr brought a bug report where netpoll causes trace
messages in the log on igb.
Danielle brought this back up as still occurring, so we'll try
again.
[22038.710800] ------------[ cut here ]------------
[22038.710801] igb_poll+0x0/0x1440 [igb] exceeded budget in poll
[22038.710802] WARNING: CPU: 12 PID: 40362 at net/core/netpoll.c:155 netpoll_poll_dev+0x18a/0x1a0
As Alex suggested, change the driver to return work_done at the
exit of napi_poll, which should be safe to do in this driver
because it is not polling multiple queues in this single napi
context (multiple queues attached to one MSI-X vector). Several
other drivers contain the same simple sequence, so I hope
this will not create new problems.
Fixes: 16eb8815c235 ("igb: Refactor clean_rx_irq to reduce overhead and improve performance")
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reported-by: Danielle Ratson <danieller@nvidia.com>
Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Tested-by: Danielle Ratson <danieller@nvidia.com>
Link: https://lore.kernel.org/r/20211123204000.1597971-1-jesse.brandeburg@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/mdio')
0 files changed, 0 insertions, 0 deletions