diff options
| author | Rob Herring (Arm) <robh@kernel.org> | 2024-07-31 14:15:15 -0600 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-01 18:13:15 -0700 |
| commit | 0b0e9cdb3d1f8fda823b592b0667b4b0595e2ba7 (patch) | |
| tree | 50ddbb8fd9afc2fdef789e317cb47330c4b3ccc5 /drivers/net/mdio | |
| parent | 46e6acfe3501fa938af9c5bd730f0020235b08a2 (diff) | |
| download | lwn-0b0e9cdb3d1f8fda823b592b0667b4b0595e2ba7.tar.gz lwn-0b0e9cdb3d1f8fda823b592b0667b4b0595e2ba7.zip | |
net: mdio: Use of_property_count_u32_elems() to get property length
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.
This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731201514.1839974-2-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/mdio')
| -rw-r--r-- | drivers/net/mdio/of_mdio.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index 08e607f62e10..2f4fc664d2e1 100644 --- a/drivers/net/mdio/of_mdio.c +++ b/drivers/net/mdio/of_mdio.c @@ -390,7 +390,7 @@ EXPORT_SYMBOL(of_phy_get_and_connect); bool of_phy_is_fixed_link(struct device_node *np) { struct device_node *dn; - int len, err; + int err; const char *managed; /* New binding */ @@ -405,8 +405,7 @@ bool of_phy_is_fixed_link(struct device_node *np) return true; /* Old binding */ - if (of_get_property(np, "fixed-link", &len) && - len == (5 * sizeof(__be32))) + if (of_property_count_u32_elems(np, "fixed-link") == 5) return true; return false; |