diff options
| author | Daniel Machon <daniel.machon@microchip.com> | 2024-12-05 14:54:24 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-12-09 13:30:16 +0000 |
| commit | 1cd7523f4baaf03026974553978210dc39e96665 (patch) | |
| tree | 65541a586fb5dce0b1fffa38ce7f844064a77af7 /drivers/net/ethernet/microchip/sparx5/Kconfig | |
| parent | 09310cfd4ea5c3ab2c7a610420205e0a1660bf7e (diff) | |
| download | lwn-1cd7523f4baaf03026974553978210dc39e96665.tar.gz lwn-1cd7523f4baaf03026974553978210dc39e96665.zip | |
net: lan969x: fix cyclic dependency reported by depmod
Depmod reports a cyclic dependency between modules sparx5-switch.ko and
lan969x-switch.ko:
depmod: ERROR: Cycle detected: lan969x_switch -> sparx5_switch -> lan969x_switch
depmod: ERROR: Found 2 modules in dependency cycles!
make[2]: *** [scripts/Makefile.modinst:132: depmod] Error 1
make: *** [Makefile:224: __sub-make] Error 2
This makes sense, as they both require symbols from each other.
Fix this by compiling lan969x support into the sparx5-switch.ko module.
In order to do this, in a sensible way, we move the lan969x/ dir into
the sparx5/ dir and do some code cleanup of code that is no longer
required.
After this patch, depmod will no longer complain, as lan969x support is
compiled into the sparx5-swicth.ko module, and can no longer be compiled
as a standalone module.
Fixes: 98a01119608d ("net: sparx5: add compatible string for lan969x")
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip/sparx5/Kconfig')
| -rw-r--r-- | drivers/net/ethernet/microchip/sparx5/Kconfig | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/ethernet/microchip/sparx5/Kconfig b/drivers/net/ethernet/microchip/sparx5/Kconfig index 3f04992eace6..35b057c9d0cb 100644 --- a/drivers/net/ethernet/microchip/sparx5/Kconfig +++ b/drivers/net/ethernet/microchip/sparx5/Kconfig @@ -24,3 +24,9 @@ config SPARX5_DCB DSCP and PCP. If unsure, set to Y. + +config LAN969X_SWITCH + bool "Lan969x switch driver" + depends on SPARX5_SWITCH + help + This driver supports the lan969x family of network switch devices. |