diff options
| author | Tudor Ambarus <tudor.ambarus@linaro.org> | 2024-10-29 08:00:49 +0000 |
|---|---|---|
| committer | Tudor Ambarus <tudor.ambarus@linaro.org> | 2024-11-11 12:26:04 +0200 |
| commit | f8f6224948d83792e9eef798d8a2407e91a51331 (patch) | |
| tree | 8e459e324cf17696dab04a418e03c323876cddc5 /drivers/mtd | |
| parent | b61c35e3404557779ec427c077f7a9f057bb053d (diff) | |
| download | lwn-f8f6224948d83792e9eef798d8a2407e91a51331.tar.gz lwn-f8f6224948d83792e9eef798d8a2407e91a51331.zip | |
mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression")
upstream fixed a regression for flavors of 0xef4018 flash that don't
define SFDP tables. Add a comment on the flash definition highlighting
that there are flavors of flashes with and without SFDP support.
It spares developers searching the entire git log for when we'll better
handle these cases.
Acked-by: Pratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20241029080049.96679-1-tudor.ambarus@linaro.org
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/spi-nor/winbond.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 9f7ce5763e71..8d0a00d69e12 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = { .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, }, { .id = SNOR_ID(0xef, 0x40, 0x18), + /* Flavors w/ and w/o SFDP. */ .name = "w25q128", .size = SZ_16M, .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, |