summaryrefslogtreecommitdiff
path: root/drivers/misc
diff options
context:
space:
mode:
authorParker Newman <pnewman@connecttech.com>2024-10-02 11:12:34 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-11 08:42:03 +0200
commitd45109c53272c88afc7db84779d0a845a12ed9fc (patch)
tree992f972050fa692d2c26ba4c0655d3904158fe0b /drivers/misc
parent7738a7ab9d12c5371ed97114ee2132d4512e9fd5 (diff)
downloadlwn-d45109c53272c88afc7db84779d0a845a12ed9fc.tar.gz
lwn-d45109c53272c88afc7db84779d0a845a12ed9fc.zip
misc: eeprom: eeprom_93cx6: Switch to BIT() macro
Use the BIT() macro rather than (1 << (i - 1)). Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Parker Newman <pnewman@connecttech.com> Link: https://lore.kernel.org/r/f40d21d284816a62003975e237a58b489d77c7d4.1727880931.git.pnewman@connecttech.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/eeprom/eeprom_93cx6.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/misc/eeprom/eeprom_93cx6.c b/drivers/misc/eeprom/eeprom_93cx6.c
index 4c9827fe9217..e6f0e0fc1ca2 100644
--- a/drivers/misc/eeprom/eeprom_93cx6.c
+++ b/drivers/misc/eeprom/eeprom_93cx6.c
@@ -8,6 +8,7 @@
* Supported chipsets: 93c46 & 93c66.
*/
+#include <linux/bits.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/delay.h>
@@ -102,7 +103,7 @@ static void eeprom_93cx6_write_bits(struct eeprom_93cx6 *eeprom,
/*
* Check if this bit needs to be set.
*/
- eeprom->reg_data_in = !!(data & (1 << (i - 1)));
+ eeprom->reg_data_in = !!(data & BIT(i - 1));
/*
* Write the bit to the eeprom register.
@@ -152,7 +153,7 @@ static void eeprom_93cx6_read_bits(struct eeprom_93cx6 *eeprom,
* Read if the bit has been set.
*/
if (eeprom->reg_data_out)
- buf |= (1 << (i - 1));
+ buf |= BIT(i - 1);
eeprom_93cx6_pulse_low(eeprom);
}