summaryrefslogtreecommitdiff
path: root/drivers/misc
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2022-11-29 12:45:16 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-20 13:22:11 +0100
commit5023adc364df004bd8e57afe89a4bd8019485c3d (patch)
tree7de015d4c2e68e3ca5fe0303538adb14a5930b49 /drivers/misc
parent0c4d68261717f89fa8c4f98a6967c3832fcb3ad0 (diff)
downloadlwn-5023adc364df004bd8e57afe89a4bd8019485c3d.tar.gz
lwn-5023adc364df004bd8e57afe89a4bd8019485c3d.zip
misc: fastrpc: fix error code in fastrpc_req_mmap()
The "err" variable shadows an earlier global variable so this code returns success instead of a negative error code. Fixes: 532ad70c6d44 ("misc: fastrpc: Add mmap request assigning for static PD pool") Signed-off-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/Y4XUrMETCl1O6t0A@kili Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/fastrpc.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index c9902a1dcf5d..876f0f146b16 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1894,7 +1894,6 @@ static int fastrpc_req_mmap(struct fastrpc_user *fl, char __user *argp)
/* Add memory to static PD pool, protection thru hypervisor */
if (req.flags != ADSP_MMAP_REMOTE_HEAP_ADDR && fl->cctx->vmcount) {
struct qcom_scm_vmperm perm;
- int err = 0;
perm.vmid = QCOM_SCM_VMID_HLOS;
perm.perm = QCOM_SCM_PERM_RWX;