diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-01-29 17:37:24 +0300 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2021-02-08 13:54:40 +0000 |
| commit | 26783d74cc6a440ee3ef9836a008a697981013d0 (patch) | |
| tree | 62c46c1bde92a726a3a852ed54b07cc0dede7e3d /drivers/mfd/wm831x-auxadc.c | |
| parent | 6a8fac01dc1c6508dd7cab876170024070b71039 (diff) | |
| download | lwn-26783d74cc6a440ee3ef9836a008a697981013d0.tar.gz lwn-26783d74cc6a440ee3ef9836a008a697981013d0.zip | |
mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()
The "req" struct is always added to the "wm831x->auxadc_pending" list,
but it's only removed from the list on the success path. If a failure
occurs then the "req" struct is freed but it's still on the list,
leading to a use after free.
Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/wm831x-auxadc.c')
| -rw-r--r-- | drivers/mfd/wm831x-auxadc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mfd/wm831x-auxadc.c b/drivers/mfd/wm831x-auxadc.c index 8a7cc0f86958..65b98f3fbd92 100644 --- a/drivers/mfd/wm831x-auxadc.c +++ b/drivers/mfd/wm831x-auxadc.c @@ -93,11 +93,10 @@ static int wm831x_auxadc_read_irq(struct wm831x *wm831x, wait_for_completion_timeout(&req->done, msecs_to_jiffies(500)); mutex_lock(&wm831x->auxadc_lock); - - list_del(&req->list); ret = req->val; out: + list_del(&req->list); mutex_unlock(&wm831x->auxadc_lock); kfree(req); |