diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2012-09-09 07:30:02 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-09-13 17:52:58 -0300 |
| commit | 844db450e6e2cf710752af1a019a877af390b541 (patch) | |
| tree | 0c43bce1f503d14cabdad012ff00b6a9c6ad41b8 /drivers/media/usb/gspca/sq905c.c | |
| parent | ff8f25d326da5e7cf6216f368116744341fceb12 (diff) | |
| download | lwn-844db450e6e2cf710752af1a019a877af390b541.tar.gz lwn-844db450e6e2cf710752af1a019a877af390b541.zip | |
[media] gspca: Update / fix various comments wrt workqueue usb_lock usage
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/usb/gspca/sq905c.c')
| -rw-r--r-- | drivers/media/usb/gspca/sq905c.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/media/usb/gspca/sq905c.c b/drivers/media/usb/gspca/sq905c.c index 784620c102b1..410cdcbb55d4 100644 --- a/drivers/media/usb/gspca/sq905c.c +++ b/drivers/media/usb/gspca/sq905c.c @@ -123,15 +123,13 @@ static int sq905c_read(struct gspca_dev *gspca_dev, u16 command, u16 index, return 0; } -/* This function is called as a workqueue function and runs whenever the camera +/* + * This function is called as a workqueue function and runs whenever the camera * is streaming data. Because it is a workqueue function it is allowed to sleep * so we can use synchronous USB calls. To avoid possible collisions with other - * threads attempting to use the camera's USB interface the gspca usb_lock is - * used when performing the one USB control operation inside the workqueue, - * which tells the camera to close the stream. In practice the only thing - * which needs to be protected against is the usb_set_interface call that - * gspca makes during stream_off. Otherwise the camera doesn't provide any - * controls that the user could try to change. + * threads attempting to use gspca_dev->usb_buf we take the usb_lock when + * performing USB operations using it. In practice we don't really need this + * as the camera doesn't provide any controls. */ static void sq905c_dostream(struct work_struct *work) { |