diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-08-23 17:02:17 +0800 |
|---|---|---|
| committer | Hans Verkuil <hverkuil@xs4all.nl> | 2025-06-17 10:51:34 +0200 |
| commit | 5211354f2cc081c236dc0c21d04d09c1ccb48b88 (patch) | |
| tree | d7a5e158e3f59c3585f6045f0a88ca22df01d243 /drivers/media/platform/xilinx | |
| parent | a7569179d3b9b341db28dc6b82f9d6507c66ec2d (diff) | |
| download | lwn-5211354f2cc081c236dc0c21d04d09c1ccb48b88.tar.gz lwn-5211354f2cc081c236dc0c21d04d09c1ccb48b88.zip | |
media: xilinx-vipp: Use for_each_child_of_node_scoped()
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Diffstat (limited to 'drivers/media/platform/xilinx')
| -rw-r--r-- | drivers/media/platform/xilinx/xilinx-vipp.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index 024b439feec9..30675f681410 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -450,7 +450,6 @@ static int xvip_graph_dma_init_one(struct xvip_composite_device *xdev, static int xvip_graph_dma_init(struct xvip_composite_device *xdev) { struct device_node *ports; - struct device_node *port; int ret = 0; ports = of_get_child_by_name(xdev->dev->of_node, "ports"); @@ -459,12 +458,10 @@ static int xvip_graph_dma_init(struct xvip_composite_device *xdev) return -EINVAL; } - for_each_child_of_node(ports, port) { + for_each_child_of_node_scoped(ports, port) { ret = xvip_graph_dma_init_one(xdev, port); - if (ret) { - of_node_put(port); + if (ret) break; - } } of_node_put(ports); |