diff options
author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2016-04-03 16:31:03 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-06-16 07:35:02 -0300 |
commit | 83934b75c368f529d084815c463a7ef781dc9751 (patch) | |
tree | 670b1628a06847218452a43d6afbbbcb4e807c4c /drivers/media/platform/rcar-vin | |
parent | 126f40298446a82116e1f92a1aaf72b8c8228fae (diff) | |
download | lwn-83934b75c368f529d084815c463a7ef781dc9751.tar.gz lwn-83934b75c368f529d084815c463a7ef781dc9751.zip |
[media] videobuf2-v4l2: Verify planes array in buffer dequeueing
When a buffer is being dequeued using VIDIOC_DQBUF IOCTL, the exact buffer
which will be dequeued is not known until the buffer has been removed from
the queue. The number of planes is specific to a buffer, not to the queue.
This does lead to the situation where multi-plane buffers may be requested
and queued with n planes, but VIDIOC_DQBUF IOCTL may be passed an argument
struct with fewer planes.
__fill_v4l2_buffer() however uses the number of planes from the dequeued
videobuf2 buffer, overwriting kernel memory (the m.planes array allocated
in video_usercopy() in v4l2-ioctl.c) if the user provided fewer
planes than the dequeued buffer had. Oops!
Fixes: b0e0e1f83de3 ("[media] media: videobuf2: Prepare to divide videobuf2")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: stable@vger.kernel.org # for v4.4 and later
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/rcar-vin')
0 files changed, 0 insertions, 0 deletions