diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-09-03 14:12:36 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-09-23 08:31:39 -0400 |
| commit | 5f4d34693cfb217354e079789864ed8801b0d39d (patch) | |
| tree | e94fe32eb07054ad548a396b35a05a3c0e73f94d /drivers/media/pci/saa7146 | |
| parent | 84c62fb996721897623337e9ebd19f9846873b55 (diff) | |
| download | lwn-5f4d34693cfb217354e079789864ed8801b0d39d.tar.gz lwn-5f4d34693cfb217354e079789864ed8801b0d39d.zip | |
media: Hexium Orion: Adjust one function call together with a variable assignment
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code place.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci/saa7146')
| -rw-r--r-- | drivers/media/pci/saa7146/hexium_orion.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/pci/saa7146/hexium_orion.c b/drivers/media/pci/saa7146/hexium_orion.c index 7dc182202f8b..043318aa19e2 100644 --- a/drivers/media/pci/saa7146/hexium_orion.c +++ b/drivers/media/pci/saa7146/hexium_orion.c @@ -266,7 +266,9 @@ static int hexium_probe(struct saa7146_dev *dev) /* check if this is an old hexium Orion card by looking at a saa7110 at address 0x4e */ - if (0 == (err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ, 0x00, I2C_SMBUS_BYTE_DATA, &data))) { + err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ, + 0x00, I2C_SMBUS_BYTE_DATA, &data); + if (err == 0) { pr_info("device is a Hexium HV-PCI6/Orion (old)\n"); /* we store the pointer in our private data field */ dev->ext_priv = hexium; |