diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2024-06-06 20:29:18 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2024-06-26 16:56:03 +0100 |
| commit | 7f9ab862e05c5bc755f65bf6db7edcffb3b49dfc (patch) | |
| tree | 4586b3dbeb04577de135fb011b06b276c5165aba /drivers/leds/leds-spi-byte.c | |
| parent | e1524a62991f284b3a552c009759ea126d7a096a (diff) | |
| download | lwn-7f9ab862e05c5bc755f65bf6db7edcffb3b49dfc.tar.gz lwn-7f9ab862e05c5bc755f65bf6db7edcffb3b49dfc.zip | |
leds: spi-byte: Call of_node_put() on error path
Add a missing call to of_node_put(np) on error.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240606173037.3091598-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds/leds-spi-byte.c')
| -rw-r--r-- | drivers/leds/leds-spi-byte.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/leds/leds-spi-byte.c b/drivers/leds/leds-spi-byte.c index 96296db5f410..b04cf502e603 100644 --- a/drivers/leds/leds-spi-byte.c +++ b/drivers/leds/leds-spi-byte.c @@ -91,7 +91,6 @@ static int spi_byte_probe(struct spi_device *spi) dev_err(dev, "Device must have exactly one LED sub-node."); return -EINVAL; } - child = of_get_next_available_child(dev_of_node(dev), NULL); led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); if (!led) @@ -104,11 +103,13 @@ static int spi_byte_probe(struct spi_device *spi) led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value; led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking; + child = of_get_next_available_child(dev_of_node(dev), NULL); state = of_get_property(child, "default-state", NULL); if (state) { if (!strcmp(state, "on")) { led->ldev.brightness = led->ldev.max_brightness; } else if (strcmp(state, "off")) { + of_node_put(child); /* all other cases except "off" */ dev_err(dev, "default-state can only be 'on' or 'off'"); return -EINVAL; @@ -123,9 +124,12 @@ static int spi_byte_probe(struct spi_device *spi) ret = devm_led_classdev_register_ext(&spi->dev, &led->ldev, &init_data); if (ret) { + of_node_put(child); mutex_destroy(&led->mutex); return ret; } + + of_node_put(child); spi_set_drvdata(spi, led); return 0; |