diff options
| author | Robin Murphy <robin.murphy@arm.com> | 2021-04-01 14:56:26 +0100 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2021-04-16 17:20:45 +0200 |
| commit | 2d471b20c55e13c98d1dba413bf2de618e89cdac (patch) | |
| tree | fe16cf7ce737c7c60d0cd414199cab0bfb4aea47 /drivers/iommu/mtk_iommu.c | |
| parent | c0aec6680b6c82fe893a546e322e1130cd5cf21e (diff) | |
| download | lwn-2d471b20c55e13c98d1dba413bf2de618e89cdac.tar.gz lwn-2d471b20c55e13c98d1dba413bf2de618e89cdac.zip | |
iommu: Streamline registration interface
Rather than have separate opaque setter functions that are easy to
overlook and lead to repetitive boilerplate in drivers, let's pass the
relevant initialisation parameters directly to iommu_device_register().
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/ab001b87c533b6f4db71eb90db6f888953986c36.1617285386.git.robin.murphy@arm.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/mtk_iommu.c')
| -rw-r--r-- | drivers/iommu/mtk_iommu.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index cdda3a85fc08..e06b8a0e2b56 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -892,10 +892,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) if (ret) goto out_link_remove; - iommu_device_set_ops(&data->iommu, &mtk_iommu_ops); - iommu_device_set_fwnode(&data->iommu, &pdev->dev.of_node->fwnode); - - ret = iommu_device_register(&data->iommu); + ret = iommu_device_register(&data->iommu, &mtk_iommu_ops, dev); if (ret) goto out_sysfs_remove; |