diff options
| author | Steve Wise <larrystevenwise@gmail.com> | 2019-12-02 20:03:20 -0600 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2019-12-09 13:55:26 -0500 |
| commit | 2030abddec6884aaf5892f5724c48fc340e6826f (patch) | |
| tree | fe5bbe9e2b18805e7c0270b80f39bffa3f71db68 /drivers/infiniband/sw/rxe/rxe_recv.c | |
| parent | 71bbac6e2f23e946875475ce2fb9f6752900d463 (diff) | |
| download | lwn-2030abddec6884aaf5892f5724c48fc340e6826f.tar.gz lwn-2030abddec6884aaf5892f5724c48fc340e6826f.zip | |
rxe: correctly calculate iCRC for unaligned payloads
If RoCE PDUs being sent or received contain pad bytes, then the iCRC
is miscalculated, resulting in PDUs being emitted by RXE with an incorrect
iCRC, as well as ingress PDUs being dropped due to erroneously detecting
a bad iCRC in the PDU. The fix is to include the pad bytes, if any,
in iCRC computations.
Note: This bug has caused broken on-the-wire compatibility with actual
hardware RoCE devices since the soft-RoCE driver was first put into the
mainstream kernel. Fixing it will create an incompatibility with the
original soft-RoCE devices, but is necessary to be compatible with real
hardware devices.
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Steve Wise <larrystevenwise@gmail.com>
Link: https://lore.kernel.org/r/20191203020319.15036-2-larrystevenwise@gmail.com
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/sw/rxe/rxe_recv.c')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_recv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c index f9a492ed900b..831ad578a7b2 100644 --- a/drivers/infiniband/sw/rxe/rxe_recv.c +++ b/drivers/infiniband/sw/rxe/rxe_recv.c @@ -389,7 +389,7 @@ void rxe_rcv(struct sk_buff *skb) calc_icrc = rxe_icrc_hdr(pkt, skb); calc_icrc = rxe_crc32(rxe, calc_icrc, (u8 *)payload_addr(pkt), - payload_size(pkt)); + payload_size(pkt) + bth_pad(pkt)); calc_icrc = (__force u32)cpu_to_be32(~calc_icrc); if (unlikely(calc_icrc != pack_icrc)) { if (skb->protocol == htons(ETH_P_IPV6)) |