diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2022-02-11 19:14:55 +0100 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2022-03-01 15:58:41 +0100 |
| commit | 68ea1b2c3386ad484b7daa4a64fa7b3be661607f (patch) | |
| tree | 1e367c0d36087c54d2821b1d261b7af55d9401f5 /drivers/i2c | |
| parent | 24e3bb7429bde31e9a28a46ca2fd6deaab257c30 (diff) | |
| download | lwn-68ea1b2c3386ad484b7daa4a64fa7b3be661607f.tar.gz lwn-68ea1b2c3386ad484b7daa4a64fa7b3be661607f.zip | |
i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify().
The i2c-i801 driver invokes i2c_handle_smbus_host_notify() from his
interrupt service routine. On PREEMPT_RT i2c-i801's handler is forced
threaded with enabled interrupts which leads to a warning by
handle_irq_event_percpu() assuming that irq_default_primary_handler()
enabled interrupts.
i2c-i801's interrupt handler can't be made non-threaded because the
interrupt line is shared with other devices.
Use generic_handle_irq_safe() which can invoked with disabled and enabled
interrupts.
Reported-by: Michael Below <below@judiz.de>
Link: https://bugs.debian.org/1002537
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/i2c-core-base.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 32a45260c1f3..d43db2c3876e 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -1424,7 +1424,7 @@ int i2c_handle_smbus_host_notify(struct i2c_adapter *adap, unsigned short addr) if (irq <= 0) return -ENXIO; - generic_handle_irq(irq); + generic_handle_irq_safe(irq); return 0; } |