diff options
| author | Jean Delvare <jdelvare@suse.de> | 2022-03-03 17:42:56 +0100 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2022-03-11 21:33:08 +0100 |
| commit | 52c74d17d89c6e69f9b774cdd477517e62383f55 (patch) | |
| tree | c93a2592fcf7165e086eb9ef6c322c4d3c210ef9 /drivers/i2c | |
| parent | 1d366c2f9df8279df2adbb60471f86fc40a1c39e (diff) | |
| download | lwn-52c74d17d89c6e69f9b774cdd477517e62383f55.tar.gz lwn-52c74d17d89c6e69f9b774cdd477517e62383f55.zip | |
i2c: i801: Drop two outdated comments
* Timeouts are reported even in interrupt mode since commit
b3b8df97723d ("i2c: i801: Use wait_event_timeout to wait for
interrupts") so drop the comment which claims this only happens in
polled mode.
* xact does not include the PEC bit, as the driver does not support
software PEC.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-i801.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 1fc006a1d532..ff706349bdfb 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -364,9 +364,6 @@ static int i801_check_post(struct i801_priv *priv, int status) /* * If the SMBus is still busy, we give up - * Note: This timeout condition only happens when using polling - * transactions. For interrupt operation, NAK/timeout is indicated by - * DEV_ERR. */ if (unlikely(status < 0)) { dev_err(&priv->pci_dev->dev, "Transaction timeout\n"); @@ -475,8 +472,6 @@ static int i801_transaction(struct i801_priv *priv, int xact) return i801_check_post(priv, result ? priv->status : -ETIMEDOUT); } - /* the current contents of SMBHSTCNT can be overwritten, since PEC, - * SMBSCMD are passed in xact */ outb_p(xact | SMBHSTCNT_START, SMBHSTCNT(priv)); status = i801_wait_intr(priv); |