diff options
| author | José Expósito <jose.exposito89@gmail.com> | 2022-12-26 13:57:36 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2023-01-18 09:47:04 +0100 |
| commit | f5379a01d6617c887db4ba81732250725ac0bec5 (patch) | |
| tree | fe6ce2a9bf7fd2f22e873aafcc249d7115ef7a26 /drivers/hid/hid-uclogic-rdesc-test.c | |
| parent | 9266a88156d1fbb8e50d6eeff7bac44ad4eaecc2 (diff) | |
| download | lwn-f5379a01d6617c887db4ba81732250725ac0bec5.tar.gz lwn-f5379a01d6617c887db4ba81732250725ac0bec5.zip | |
HID: uclogic: Use KUNIT_EXPECT_MEMEQ
Commit b8a926bea8b1 ("kunit: Introduce KUNIT_EXPECT_MEMEQ and
KUNIT_EXPECT_MEMNEQ macros") introduced a new macro to compare blocks of
memory and, if the test fails, print the result in a human friendly
format. For example, this is the output of a test failure:
Expected res == params->expected, but
res ==
01 02 aa 00 00 00 03 bb 00 <00> 00 04 05
params->expected ==
01 02 aa 00 00 00 03 bb 00 <01> 00 04 05
Use this new macro to replace KUNIT_EXPECT_EQ + memcmp.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Maíra Canal <mairacanal@riseup.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-uclogic-rdesc-test.c')
| -rw-r--r-- | drivers/hid/hid-uclogic-rdesc-test.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/hid/hid-uclogic-rdesc-test.c b/drivers/hid/hid-uclogic-rdesc-test.c index b429c541bf2f..90bf4e586e01 100644 --- a/drivers/hid/hid-uclogic-rdesc-test.c +++ b/drivers/hid/hid-uclogic-rdesc-test.c @@ -197,8 +197,7 @@ static void hid_test_uclogic_template(struct kunit *test) params->param_list, params->param_num); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, res); - KUNIT_EXPECT_EQ(test, 0, - memcmp(res, params->expected, params->template_size)); + KUNIT_EXPECT_MEMEQ(test, res, params->expected, params->template_size); kfree(res); } |