diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-07-13 15:25:51 +0100 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2020-07-13 15:45:32 +0100 |
| commit | d2921096e707bdde92bc635cd89ec1fe85a9faee (patch) | |
| tree | 030ddeca2a5af763c971d564a590522e7a1ffccb /drivers/gpu/drm | |
| parent | 4fe6abb8f51355224808ab02a9febf65d184c40b (diff) | |
| download | lwn-d2921096e707bdde92bc635cd89ec1fe85a9faee.tar.gz lwn-d2921096e707bdde92bc635cd89ec1fe85a9faee.zip | |
drm/i915/selftest: fix an error return path where err is not being set
There is an error condition where err is not being set and an uninitialized
garbage value in err is being returned. Fix this by assigning err to an
appropriate error return value before taking the error exit path.
Addresses-Coverity: ("Uninitialized scalar value")
Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200713142551.423649-1-colin.king@canonical.com
Diffstat (limited to 'drivers/gpu/drm')
| -rw-r--r-- | drivers/gpu/drm/i915/selftests/i915_perf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c index deb6dec1b5ab..0aa151501fb3 100644 --- a/drivers/gpu/drm/i915/selftests/i915_perf.c +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c @@ -328,6 +328,7 @@ static int live_noa_gpr(void *arg) /* Fill the 16 qword [32 dword] GPR with a known unlikely value */ cs = intel_ring_begin(rq, 2 * 32 + 2); if (IS_ERR(cs)) { + err = PTR_ERR(cs); i915_request_add(rq); goto out_rq; } |