diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-10-18 09:09:19 +0300 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2011-10-18 10:41:11 +0100 |
| commit | d2c184fb10656f2a6d59fef76efb3a8b12fb6ed4 (patch) | |
| tree | ec6b13518ca0bc7ef4b460d01671ff3c4c3294ac /drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | |
| parent | bd8315c4a8ade3c0cd6c1933ae6e453958397d22 (diff) | |
| download | lwn-d2c184fb10656f2a6d59fef76efb3a8b12fb6ed4.tar.gz lwn-d2c184fb10656f2a6d59fef76efb3a8b12fb6ed4.zip | |
vmwgfx: return -EFAULT instead of number of bytes remaining
The intent here was to return an error code, but instead the code
returns the number of bytes remaining (that weren't copied).
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c')
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c index 97f23abeacda..3f6343502d1f 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c @@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data, ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips)); if (ret) { DRM_ERROR("Failed to copy clip rects from userspace.\n"); + ret = -EFAULT; goto out_no_copy; } @@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data, ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips)); if (ret) { DRM_ERROR("Failed to copy clip rects from userspace.\n"); + ret = -EFAULT; goto out_no_copy; } |