diff options
| author | Eric Anholt <eric@anholt.net> | 2018-12-03 14:24:38 -0800 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2018-12-07 10:56:51 -0800 |
| commit | aa5beec32e8b78bfcf621e3c3daebfb1644b6365 (patch) | |
| tree | 43f78bef5a8d60b709424114f850367ae22a7d27 /drivers/gpu/drm/v3d/v3d_gem.c | |
| parent | 7b9d2fe4350a9c12f66ad8cc78c1098226f6c3c2 (diff) | |
| download | lwn-aa5beec32e8b78bfcf621e3c3daebfb1644b6365.tar.gz lwn-aa5beec32e8b78bfcf621e3c3daebfb1644b6365.zip | |
drm/v3d: Invalidate the caches from the outside in.
This would be a fairly obscure race, but let's make sure we don't ever
lose it.
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20181203222438.25417-6-eric@anholt.net
Reviewed-by: Dave Emett <david.emett@broadcom.com>
Diffstat (limited to 'drivers/gpu/drm/v3d/v3d_gem.c')
| -rw-r--r-- | drivers/gpu/drm/v3d/v3d_gem.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 06525ea9ec50..803f31467ec1 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -171,11 +171,15 @@ v3d_invalidate_slices(struct v3d_dev *v3d, int core) void v3d_invalidate_caches(struct v3d_dev *v3d) { + /* Invalidate the caches from the outside in. That way if + * another CL's concurrent use of nearby memory were to pull + * an invalidated cacheline back in, we wouldn't leave stale + * data in the inner cache. + */ v3d_flush_l3(v3d); - v3d_invalidate_l2c(v3d, 0); - v3d_invalidate_slices(v3d, 0); v3d_flush_l2t(v3d, 0); + v3d_invalidate_slices(v3d, 0); } static void |