diff options
author | Jonathan Liu <net147@gmail.com> | 2020-10-31 19:17:47 +1100 |
---|---|---|
committer | Sam Ravnborg <sam@ravnborg.org> | 2020-11-12 22:21:00 +0100 |
commit | bc551d776b691022f49b5bb5379bd58f7c4eb76a (patch) | |
tree | 9ec6f419311d46b7da171989f26a0701fe9f8650 /drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | |
parent | a6c40b8032b845f132abfcbcbed6bddebbcc3b4a (diff) | |
download | lwn-bc551d776b691022f49b5bb5379bd58f7c4eb76a.tar.gz lwn-bc551d776b691022f49b5bb5379bd58f7c4eb76a.zip |
drm: bridge: dw-hdmi: Avoid resetting force in the detect function
It has been observed that resetting force in the detect function can
result in the PHY being powered down in response to hot-plug detect
being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to dump_stack() in
dw_hdmi_phy_power_off() shows the following in dmesg:
[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin
[ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
Call trace:
dw_hdmi_phy_power_off
dw_hdmi_phy_disable
dw_hdmi_update_power
dw_hdmi_detect
dw_hdmi_connector_detect
drm_helper_probe_detect_ctx
drm_helper_hpd_irq_event
dw_hdmi_irq
irq_thread_fn
irq_thread
kthread
ret_from_fork
Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")
Signed-off-by: Jonathan Liu <net147@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201031081747.372599-1-net147@gmail.com
Diffstat (limited to 'drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c')
0 files changed, 0 insertions, 0 deletions