diff options
| author | José Roberto de Souza <jose.souza@intel.com> | 2019-03-01 16:33:47 -0800 |
|---|---|---|
| committer | José Roberto de Souza <jose.souza@intel.com> | 2019-03-04 14:41:58 -0800 |
| commit | a551cd66bc0a15ba00433743094c2453e1ee7aa9 (patch) | |
| tree | fb8e763cd70e4b4f6869a22c7495a57b477d0e25 /drivers/gpu/drm/i915/intel_ddi.c | |
| parent | 3e1d87ddcf6298fd32ba4857173edd9e559897cf (diff) | |
| download | lwn-a551cd66bc0a15ba00433743094c2453e1ee7aa9.tar.gz lwn-a551cd66bc0a15ba00433743094c2453e1ee7aa9.zip | |
drm/i915: Fix atomic state leak when resetting HDMI link
Atomic state needs to be put even if the commit was successful.
Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD")
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190302003349.19189-1-jose.souza@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_ddi.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_ddi.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index d918be927fc2..34dd5823398a 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -3984,12 +3984,7 @@ static int modeset_pipe(struct drm_crtc *crtc, goto out; ret = drm_atomic_commit(state); - if (ret) - goto out; - - return 0; - - out: +out: drm_atomic_state_put(state); return ret; |