diff options
| author | Alex Hung <alex.hung@amd.com> | 2024-06-11 11:45:42 -0600 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2024-06-27 17:10:38 -0400 |
| commit | 673f816b9e1e92d1f70e1bf5f21b531e0ff9ad6c (patch) | |
| tree | 3b3adcf4c2af16e38b2f0adfc8a7c9a0b0ee9f39 /drivers/gpu/drm/amd/display/dc/hubbub | |
| parent | c53bb80f49a7cea933ccb4b7a458e6983820e9a5 (diff) | |
| download | lwn-673f816b9e1e92d1f70e1bf5f21b531e0ff9ad6c.tar.gz lwn-673f816b9e1e92d1f70e1bf5f21b531e0ff9ad6c.zip | |
drm/amd/display: Validate function returns
[WHAT & HOW]
Function return values must be checked before data can be used
in subsequent functions.
This fixes 4 CHECKED_RETURN issues reported by Coverity.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/hubbub')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c b/drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c index 8901bd80f7d1..5c6f7ddafd6b 100644 --- a/drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c +++ b/drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c @@ -616,7 +616,8 @@ static bool hubbub2_program_watermarks( hubbub1->base.ctx->dc->clk_mgr->clks.p_state_change_support == false) safe_to_lower = true; - hubbub1_program_pstate_watermarks(hubbub, watermarks, refclk_mhz, safe_to_lower); + if (hubbub1_program_pstate_watermarks(hubbub, watermarks, refclk_mhz, safe_to_lower)) + wm_pending = true; REG_SET(DCHUBBUB_ARB_SAT_LEVEL, 0, DCHUBBUB_ARB_SAT_LEVEL, 60 * refclk_mhz); |