summaryrefslogtreecommitdiff
path: root/drivers/gpio/gpio-max7300.c
diff options
context:
space:
mode:
authorAlan Borzeszkowski <alan.borzeszkowski@linux.intel.com>2024-12-04 09:04:09 +0200
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2024-12-10 10:35:12 +0100
commiteb9640fd1ce666610b77f5997596e9570a36378f (patch)
tree27bff894c6801b26c6b999c0db8e8fb186c637c2 /drivers/gpio/gpio-max7300.c
parent3396995f9fb6bcbe0004a68118a22f98bab6e2b9 (diff)
downloadlwn-eb9640fd1ce666610b77f5997596e9570a36378f.tar.gz
lwn-eb9640fd1ce666610b77f5997596e9570a36378f.zip
gpio: graniterapids: Fix vGPIO driver crash
Move setting irq_chip.name from probe() function to the initialization of "irq_chip" struct in order to fix vGPIO driver crash during bootup. Crash was caused by unauthorized modification of irq_chip.name field where irq_chip struct was initialized as const. This behavior is a consequence of suboptimal implementation of gpio_irq_chip_set_chip(), which should be changed to avoid casting away const qualifier. Crash log: BUG: unable to handle page fault for address: ffffffffc0ba81c0 /#PF: supervisor write access in kernel mode /#PF: error_code(0x0003) - permissions violation CPU: 33 UID: 0 PID: 1075 Comm: systemd-udevd Not tainted 6.12.0-rc6-00077-g2e1b3cc9d7f7 #1 Hardware name: Intel Corporation Kaseyville RP/Kaseyville RP, BIOS KVLDCRB1.PGS.0026.D73.2410081258 10/08/2024 RIP: 0010:gnr_gpio_probe+0x171/0x220 [gpio_graniterapids] Cc: stable@vger.kernel.org Signed-off-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by: Andy Shevchenko <andy@kernel.org> Link: https://lore.kernel.org/r/20241204070415.1034449-2-mika.westerberg@linux.intel.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-max7300.c')
0 files changed, 0 insertions, 0 deletions