diff options
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2018-05-17 18:11:56 +1000 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2018-05-23 13:57:44 +0200 |
| commit | af7949284910a1f0b7814625051b8acf99af74d2 (patch) | |
| tree | bc66de732f8d6e68175748a99e2156b5c0ad145b /drivers/gpio/gpio-aspeed.c | |
| parent | d5dbf9c266ccf632cdf259146e4ec62b381db655 (diff) | |
| download | lwn-af7949284910a1f0b7814625051b8acf99af74d2.tar.gz lwn-af7949284910a1f0b7814625051b8acf99af74d2.zip | |
gpio: aspeed: Set output latch before changing direction
In aspeed_gpio_dir_out(), we need to establish the new output
value in the output latch *before* we change the direction
to output in order to avoid a glitch on the output line if
the previous value of the latch was different.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Tested-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-aspeed.c')
| -rw-r--r-- | drivers/gpio/gpio-aspeed.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 77e485557498..f210bed83dd6 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -287,11 +287,10 @@ static int aspeed_gpio_dir_out(struct gpio_chip *gc, spin_lock_irqsave(&gpio->lock, flags); + __aspeed_gpio_set(gc, offset, val); reg = ioread32(bank_val_reg(gpio, bank, GPIO_DIR)); iowrite32(reg | GPIO_BIT(offset), bank_val_reg(gpio, bank, GPIO_DIR)); - __aspeed_gpio_set(gc, offset, val); - spin_unlock_irqrestore(&gpio->lock, flags); return 0; |