diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2021-12-31 08:04:25 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-06 15:47:45 +0100 |
| commit | 0589e8889dce8e0f0ea5bbf757f38865e2a469c1 (patch) | |
| tree | a043ce7fca1bf8ad708b2cdd0f4b5c98be1d5a14 /drivers/firmware | |
| parent | 358fcf5ddbec4e6706405847d6a666f5933a6c25 (diff) | |
| download | lwn-0589e8889dce8e0f0ea5bbf757f38865e2a469c1.tar.gz lwn-0589e8889dce8e0f0ea5bbf757f38865e2a469c1.zip | |
drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
Add the missing platform_device_put() before return from
sysfb_create_simplefb() in the error handling case.
Fixes: 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20211231080431.15385-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/sysfb_simplefb.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c index b86761904949..303a491e520d 100644 --- a/drivers/firmware/sysfb_simplefb.c +++ b/drivers/firmware/sysfb_simplefb.c @@ -113,12 +113,16 @@ __init int sysfb_create_simplefb(const struct screen_info *si, sysfb_apply_efi_quirks(pd); ret = platform_device_add_resources(pd, &res, 1); - if (ret) + if (ret) { + platform_device_put(pd); return ret; + } ret = platform_device_add_data(pd, mode, sizeof(*mode)); - if (ret) + if (ret) { + platform_device_put(pd); return ret; + } return platform_device_add(pd); } |