diff options
| author | Ira Weiny <ira.weiny@intel.com> | 2024-11-07 14:58:22 -0600 |
|---|---|---|
| committer | Dave Jiang <dave.jiang@intel.com> | 2024-11-08 09:39:05 -0700 |
| commit | 0f6f0d687adcb4747e71f2a797acc9a739d71778 (patch) | |
| tree | 7c2d3782488ceec8e9b1aa0758ee17c99ad030b4 /drivers/cxl | |
| parent | f88b3ecc9cc737fc518b7a386d38bb2110712fa2 (diff) | |
| download | lwn-0f6f0d687adcb4747e71f2a797acc9a739d71778.tar.gz lwn-0f6f0d687adcb4747e71f2a797acc9a739d71778.zip | |
cxl/pci: Delay event buffer allocation
The event buffer does not need to be allocated if something has failed in
setting up event irq's.
In prep for adjusting event configuration for DCD events move the buffer
allocation to the end of the event configuration.
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Li Ming <ming4.li@intel.com>
Link: https://lore.kernel.org/all/663922b475e50_d54d72945b@dwillia2-xfh.jf.intel.com.notmuch/ [1]
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241107-dcd-type2-upstream-v7-4-56a84e66bc36@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers/cxl')
| -rw-r--r-- | drivers/cxl/pci.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 188412d45e0d..295779c433b2 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -764,10 +764,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, return 0; } - rc = cxl_mem_alloc_event_buf(mds); - if (rc) - return rc; - rc = cxl_event_get_int_policy(mds, &policy); if (rc) return rc; @@ -781,6 +777,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, return -EBUSY; } + rc = cxl_mem_alloc_event_buf(mds); + if (rc) + return rc; + rc = cxl_event_irqsetup(mds); if (rc) return rc; |