summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorGaosheng Cui <cuigaosheng1@huawei.com>2024-08-03 14:49:22 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2024-08-10 12:25:34 +0800
commitd57e2f7cffd57fe2800332dec768ec1b67a4159f (patch)
treee6b1504f094e6d670e64818fdd4d5812b2cf436d /drivers/char
parentda4fe6815aca25603944a64b0965310512e867d0 (diff)
downloadlwn-d57e2f7cffd57fe2800332dec768ec1b67a4159f.tar.gz
lwn-d57e2f7cffd57fe2800332dec768ec1b67a4159f.zip
hwrng: bcm2835 - Add missing clk_disable_unprepare in bcm2835_rng_init
Add the missing clk_disable_unprepare() before return in bcm2835_rng_init(). Fixes: e5f9f41d5e62 ("hwrng: bcm2835 - add reset support") Cc: <stable@vger.kernel.org> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/hw_random/bcm2835-rng.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index b03e80300627..aa2b135e3ee2 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -94,8 +94,10 @@ static int bcm2835_rng_init(struct hwrng *rng)
return ret;
ret = reset_control_reset(priv->reset);
- if (ret)
+ if (ret) {
+ clk_disable_unprepare(priv->clk);
return ret;
+ }
if (priv->mask_interrupts) {
/* mask the interrupt */