diff options
| author | Michael Neuling <mikey@neuling.org> | 2011-06-05 16:48:47 +0000 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2011-06-20 11:21:48 +1000 |
| commit | dc28518f7d7dfd93cd44edb44f9b8e961f5a5c1b (patch) | |
| tree | b49e7716451fe02ab9a5ef51aba5edcdffd29a30 /arch/powerpc/include/asm/dbell.h | |
| parent | b6935f8cd915cf11c5222cab5ecc6a45adb2270c (diff) | |
| download | lwn-dc28518f7d7dfd93cd44edb44f9b8e961f5a5c1b.tar.gz lwn-dc28518f7d7dfd93cd44edb44f9b8e961f5a5c1b.zip | |
powerpc: Fix doorbell type shift
doorbell type is defined as bits 32:36 so should be shifted by 63-36 =
27 rather than 28.
We never noticed this bug as we've only every used type PPC_DBELL = 0.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Acked-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/include/asm/dbell.h')
| -rw-r--r-- | arch/powerpc/include/asm/dbell.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/include/asm/dbell.h b/arch/powerpc/include/asm/dbell.h index 9c70d0ca96d4..efa74ac44a35 100644 --- a/arch/powerpc/include/asm/dbell.h +++ b/arch/powerpc/include/asm/dbell.h @@ -18,7 +18,7 @@ #include <asm/ppc-opcode.h> #define PPC_DBELL_MSG_BRDCAST (0x04000000) -#define PPC_DBELL_TYPE(x) (((x) & 0xf) << 28) +#define PPC_DBELL_TYPE(x) (((x) & 0xf) << (63-36)) enum ppc_dbell { PPC_DBELL = 0, /* doorbell */ PPC_DBELL_CRIT = 1, /* critical doorbell */ |