diff options
author | Guenter Roeck <linux@roeck-us.net> | 2014-12-09 14:21:45 -0800 |
---|---|---|
committer | Sasha Levin <alexander.levin@verizon.com> | 2016-10-09 21:23:56 -0400 |
commit | 54e7defb67e15b0b0f8f6505193922cb1af4eaba (patch) | |
tree | ccc097696c52c152b09f34f4ed5640d3b8f1ce16 /arch/hexagon/mm/cache.c | |
parent | f6e672ada0c9714c7d1a63054ca98c707fa916d6 (diff) | |
download | lwn-54e7defb67e15b0b0f8f6505193922cb1af4eaba.tar.gz lwn-54e7defb67e15b0b0f8f6505193922cb1af4eaba.zip |
hexagon: Fix build failures in linux-next
[ Upstream commit cb84c2b401d9cead5508cfed57b59b6d5feffdac ]
hexagon:defconfig fails to build in linux-next since commit 332fd7c4fef5
("genirq: Generic chip: Change irq_reg_{readl,writel} arguments").
The primary build failure is
arch/hexagon/include/asm/cacheflush.h: In function 'copy_to_user_page':
arch/hexagon/include/asm/cacheflush.h:89:22: error: 'VM_EXEC' undeclared
This is the result of including of <linux/io.h> from <linux/irq.h>,
which is now necessary due to the use of readl and writel from irq.h.
This causes recursive inclusions in hexagon code; cacheflush.h is included
from mm.h prior to the definition of VM_EXEC.
Fix the problem by moving copy_to_user_page from the hexagon include file to
arch/hexagon/mm/cache.c, similar to other architectures. After this change,
several redefinitions of readl and writel are reported. Those are caused
by recursive inclusions of io.h and asm/cacheflush.h. Fix those problems by
reducing the number of files included from those files. Also, it was necessary
to stop including asm-generic/cacheflush.h from asm/cacheflush.h. Instead,
functionality originally provided by asm-generic/cacheflush.h is now coded
in asm/cacheflush.h directly.
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
signed-off-by: Richard Kuo <rkuo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'arch/hexagon/mm/cache.c')
-rw-r--r-- | arch/hexagon/mm/cache.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/arch/hexagon/mm/cache.c b/arch/hexagon/mm/cache.c index 0c76c802e31c..a7c6d827d8b6 100644 --- a/arch/hexagon/mm/cache.c +++ b/arch/hexagon/mm/cache.c @@ -127,3 +127,13 @@ void flush_cache_all_hexagon(void) local_irq_restore(flags); mb(); } + +void copy_to_user_page(struct vm_area_struct *vma, struct page *page, + unsigned long vaddr, void *dst, void *src, int len) +{ + memcpy(dst, src, len); + if (vma->vm_flags & VM_EXEC) { + flush_icache_range((unsigned long) dst, + (unsigned long) dst + len); + } +} |