diff options
author | Mark Brown <broonie@kernel.org> | 2020-05-04 14:13:24 +0100 |
---|---|---|
committer | Will Deacon <will@kernel.org> | 2020-05-04 16:06:29 +0100 |
commit | 07dcd9677c5d0f4735041885d3c3c348cc11b75c (patch) | |
tree | 5bc504ea92bb1b50893cd72b2461da43ae3b37a8 /arch/arm64/kernel/probes/decode-insn.c | |
parent | bd507ca2773b20f554a3e14f7aa9080e45ee399a (diff) | |
download | lwn-07dcd9677c5d0f4735041885d3c3c348cc11b75c.tar.gz lwn-07dcd9677c5d0f4735041885d3c3c348cc11b75c.zip |
arm64: insn: Provide a better name for aarch64_insn_is_nop()
The current aarch64_insn_is_nop() has exactly one caller which uses it
solely to identify if the instruction is a HINT that can safely be stepped,
requiring us to list things that aren't NOPs and make things more confusing
than they need to be. Rename the function to reflect the actual usage and
make things more clear.
Suggested-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20200504131326.18290-3-broonie@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'arch/arm64/kernel/probes/decode-insn.c')
-rw-r--r-- | arch/arm64/kernel/probes/decode-insn.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/kernel/probes/decode-insn.c b/arch/arm64/kernel/probes/decode-insn.c index b78fac9e546c..263d5fba4c8a 100644 --- a/arch/arm64/kernel/probes/decode-insn.c +++ b/arch/arm64/kernel/probes/decode-insn.c @@ -46,7 +46,7 @@ static bool __kprobes aarch64_insn_is_steppable(u32 insn) * except for the NOP case. */ if (aarch64_insn_is_hint(insn)) - return aarch64_insn_is_nop(insn); + return aarch64_insn_is_steppable_hint(insn); return true; } |