diff options
| author | Zhengchao Shao <shaozhengchao@huawei.com> | 2023-01-04 14:51:46 +0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-01-05 10:19:36 +0100 |
| commit | fe69230f05897b3de758427b574fc98025dfc907 (patch) | |
| tree | 296cf81b112ae99a8693d7b7af43ba0a1a0f1780 | |
| parent | 1ac88557447088ccd15eb2f2520ce46d463c8e0b (diff) | |
| download | lwn-fe69230f05897b3de758427b574fc98025dfc907.tar.gz lwn-fe69230f05897b3de758427b574fc98025dfc907.zip | |
caif: fix memory leak in cfctrl_linkup_request()
When linktype is unknown or kzalloc failed in cfctrl_linkup_request(),
pkt is not released. Add release process to error path.
Fixes: b482cd2053e3 ("net-caif: add CAIF core protocol stack")
Fixes: 8d545c8f958f ("caif: Disconnect without waiting for response")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20230104065146.1153009-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | net/caif/cfctrl.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c index cc405d8c7c30..8480684f2762 100644 --- a/net/caif/cfctrl.c +++ b/net/caif/cfctrl.c @@ -269,11 +269,15 @@ int cfctrl_linkup_request(struct cflayer *layer, default: pr_warn("Request setup of bad link type = %d\n", param->linktype); + cfpkt_destroy(pkt); return -EINVAL; } req = kzalloc(sizeof(*req), GFP_KERNEL); - if (!req) + if (!req) { + cfpkt_destroy(pkt); return -ENOMEM; + } + req->client_layer = user_layer; req->cmd = CFCTRL_CMD_LINK_SETUP; req->param = *param; |