summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2014-04-07 13:39:06 +0300
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2014-05-05 09:31:33 +0300
commitfcdd57c8902a936a616df2066d873b38ef3ed364 (patch)
treee1fee915497b3efa4f1ab3397de974062ff9dc35
parent89ca3b881987f5a4be4c5dbaa7f0df12bbdde2fd (diff)
downloadlwn-fcdd57c8902a936a616df2066d873b38ef3ed364.tar.gz
lwn-fcdd57c8902a936a616df2066d873b38ef3ed364.zip
UBIFS: fix remount error path
Dan's "smatch" checker found out that there was a bug in the error path of the 'ubifs_remount_rw()' function. Instead of jumping to the "out" label which cleans-things up, we just returned. This patch fixes the problem. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
-rw-r--r--fs/ubifs/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index a1266089eca1..a81c7b556896 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1556,7 +1556,7 @@ static int ubifs_remount_rw(struct ubifs_info *c)
if (c->space_fixup) {
err = ubifs_fixup_free_space(c);
if (err)
- return err;
+ goto out;
}
err = check_free_space(c);