diff options
| author | Dirk Müller <dmueller@suse.com> | 2015-10-01 13:43:42 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-10-22 14:37:49 -0700 |
| commit | fb7eff9cfdffc4cb2f3d75024bda6c2a56ab12e6 (patch) | |
| tree | 1c40a6a3e2f65c7544fc0c1d3fa955c1bd692712 | |
| parent | 9870892fc277debf23fd5f6bef2fef5ae77b97fb (diff) | |
| download | lwn-fb7eff9cfdffc4cb2f3d75024bda6c2a56ab12e6.tar.gz lwn-fb7eff9cfdffc4cb2f3d75024bda6c2a56ab12e6.zip | |
Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
commit d2922422c48df93f3edff7d872ee4f3191fefb08 upstream.
The cpu feature flags are not ever going to change, so warning
everytime can cause a lot of kernel log spam
(in our case more than 10GB/hour).
The warning seems to only occur when nested virtualization is
enabled, so it's probably triggered by a KVM bug. This is a
sensible and safe change anyway, and the KVM bug fix might not
be suitable for stable releases anyway.
Signed-off-by: Dirk Mueller <dmueller@suse.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | arch/x86/kvm/svm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 224d2ef754cc..3deddd796f76 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -496,7 +496,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu) struct vcpu_svm *svm = to_svm(vcpu); if (svm->vmcb->control.next_rip != 0) { - WARN_ON(!static_cpu_has(X86_FEATURE_NRIPS)); + WARN_ON_ONCE(!static_cpu_has(X86_FEATURE_NRIPS)); svm->next_rip = svm->vmcb->control.next_rip; } |