diff options
| author | Oliver Neukum <oneukum@suse.de> | 2014-11-20 14:54:35 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-01-16 06:59:52 -0800 |
| commit | f1a65401680e9358d27cdb5537aca243c6ee6ad1 (patch) | |
| tree | 060f2463d2894834e589924494ea77d82cd4103f | |
| parent | ee9b142838a989550587a27fb3bb8ebbe8ab6fba (diff) | |
| download | lwn-f1a65401680e9358d27cdb5537aca243c6ee6ad1.tar.gz lwn-f1a65401680e9358d27cdb5537aca243c6ee6ad1.zip | |
cdc-acm: memory leak in error case
commit d908f8478a8d18e66c80a12adb27764920c1f1ca upstream.
If probe() fails not only the attributes need to be removed
but also the memory freed.
Reported-by: Ahmed Tamrawi <ahmedtamrawi@gmail.com>
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/class/cdc-acm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index bff1bf20eaeb..64d9c3daa856 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1476,6 +1476,7 @@ alloc_fail8: &dev_attr_wCountryCodes); device_remove_file(&acm->control->dev, &dev_attr_iCountryCodeRelDate); + kfree(acm->country_codes); } device_remove_file(&acm->control->dev, &dev_attr_bmCapabilities); alloc_fail7: |