diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-09-26 10:32:29 +0200 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2023-09-27 16:18:01 -0700 |
| commit | f1a1bc8775b26345aba2be278118999e7f661d3d (patch) | |
| tree | 65d1ebf0f9719d29d1fa4526b6ad124d7524def0 | |
| parent | 9b09c0f289c5a8fc5e9b0c1f3cd2766d33b910dc (diff) | |
| download | lwn-f1a1bc8775b26345aba2be278118999e7f661d3d.tar.gz lwn-f1a1bc8775b26345aba2be278118999e7f661d3d.zip | |
soc: qcom: llcc: Handle a second device without data corruption
Usually there is only one llcc device. But if there were a second, even
a failed probe call would modify the global drv_data pointer. So check
if drv_data is valid before overwriting it.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: a3134fb09e0b ("drivers: soc: Add LLCC driver")
Link: https://lore.kernel.org/r/20230926083229.2073890-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
| -rw-r--r-- | drivers/soc/qcom/llcc-qcom.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index feb21637ac20..e3f262a50e4a 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -1120,6 +1120,9 @@ static int qcom_llcc_probe(struct platform_device *pdev) u32 version; struct regmap *regmap; + if (!IS_ERR(drv_data)) + return -EBUSY; + drv_data = devm_kzalloc(dev, sizeof(*drv_data), GFP_KERNEL); if (!drv_data) { ret = -ENOMEM; |