diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2018-01-02 16:29:45 +0100 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2018-01-17 14:23:33 +0100 |
| commit | f18affbea8f7aebb235bfdaf3ad4c307aa5f3d64 (patch) | |
| tree | 28fc08e45297b959c2395ed008ff2f840b1bd36b | |
| parent | a8750ddca918032d6349adbf9a4b6555e7db20da (diff) | |
| download | lwn-f18affbea8f7aebb235bfdaf3ad4c307aa5f3d64.tar.gz lwn-f18affbea8f7aebb235bfdaf3ad4c307aa5f3d64.zip | |
iommu/omap: Fix debugfs_create_*() usage
When exposing data access through debugfs, the correct
debugfs_create_*() functions must be used, depending on data type.
Remove all casts from data pointers passed to debugfs_create_*()
functions, as such casts prevent the compiler from flagging bugs.
omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
a part of it. Fix this by using debugfs_create_u32() instead.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
| -rw-r--r-- | drivers/iommu/omap-iommu-debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index 505548aafeff..50217548c3b8 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -274,8 +274,8 @@ void omap_iommu_debugfs_add(struct omap_iommu *obj) if (!obj->debug_dir) return; - d = debugfs_create_u8("nr_tlb_entries", 0400, obj->debug_dir, - (u8 *)&obj->nr_tlb_entries); + d = debugfs_create_u32("nr_tlb_entries", 0400, obj->debug_dir, + &obj->nr_tlb_entries); if (!d) return; |