diff options
| author | Antonio Quartulli <antonio@meshcoding.com> | 2014-01-30 00:12:24 +0100 |
|---|---|---|
| committer | Antonio Quartulli <antonio@meshcoding.com> | 2014-02-17 17:17:01 +0100 |
| commit | f1791425cf0bcda43ab9a9a37df1ad3ccb1f6654 (patch) | |
| tree | 168bc48d9894cdf33b3065ddc5982d44605b73c4 | |
| parent | 91c2b1a9f680ff105369d49abc7e19ca7efb33e1 (diff) | |
| download | lwn-f1791425cf0bcda43ab9a9a37df1ad3ccb1f6654.tar.gz lwn-f1791425cf0bcda43ab9a9a37df1ad3ccb1f6654.zip | |
batman-adv: properly check pskb_may_pull return value
pskb_may_pull() returns 1 on success and 0 in case of failure,
therefore checking for the return value being negative does
not make sense at all.
This way if the function fails we will probably read beyond the current
skb data buffer. Fix this by doing the proper check.
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
| -rw-r--r-- | net/batman-adv/routing.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c index 1ed9f7c9ecea..c26f07368849 100644 --- a/net/batman-adv/routing.c +++ b/net/batman-adv/routing.c @@ -688,7 +688,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, int is_old_ttvn; /* check if there is enough data before accessing it */ - if (pskb_may_pull(skb, hdr_len + ETH_HLEN) < 0) + if (!pskb_may_pull(skb, hdr_len + ETH_HLEN)) return 0; /* create a copy of the skb (in case of for re-routing) to modify it. */ |