diff options
| author | Lee Jones <lee@kernel.org> | 2023-08-24 08:37:00 +0100 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2023-10-11 22:52:43 +0200 |
| commit | f170bed50f9bbc4b03673f40c91f84d4d0258409 (patch) | |
| tree | 28933db8c2a157db76e6a2b14d3fced7f1e88aef | |
| parent | 753c977b1536f6997380f6acb01c3b70dd7ca41a (diff) | |
| download | lwn-f170bed50f9bbc4b03673f40c91f84d4d0258409.tar.gz lwn-f170bed50f9bbc4b03673f40c91f84d4d0258409.zip | |
drm/tegra: hub: Increase buffer size to ensure all possible values can be stored
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230824073710.2677348-16-lee@kernel.org
| -rw-r--r-- | drivers/gpu/drm/tegra/hub.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c index 1af5f8318d91..f21e57e8599e 100644 --- a/drivers/gpu/drm/tegra/hub.c +++ b/drivers/gpu/drm/tegra/hub.c @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev) for (i = 0; i < hub->soc->num_wgrps; i++) { struct tegra_windowgroup *wgrp = &hub->wgrps[i]; - char id[8]; + char id[16]; snprintf(id, sizeof(id), "wgrp%u", i); mutex_init(&wgrp->lock); |