diff options
| author | Yohei Kanemaru <yohei.kanemaru@gmail.com> | 2019-01-29 15:52:34 +0900 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-30 14:06:12 -0800 |
| commit | ef489749aae508e6f17886775c075f12ff919fb1 (patch) | |
| tree | ca6e7ad0f0176a76a90baee3ef6af49519bacddc | |
| parent | a10cc84791b1eaa8471ff4e76a1bc8f399800a0b (diff) | |
| download | lwn-ef489749aae508e6f17886775c075f12ff919fb1.tar.gz lwn-ef489749aae508e6f17886775c075f12ff919fb1.zip | |
ipv6: sr: clear IP6CB(skb) on SRH ip4ip6 encapsulation
skb->cb may contain data from previous layers (in an observed case
IPv4 with L3 Master Device). In the observed scenario, the data in
IPCB(skb)->frags was misinterpreted as IP6CB(skb)->frag_max_size,
eventually caused an unexpected IPv6 fragmentation in ip6_fragment()
through ip6_finish_output().
This patch clears IP6CB(skb), which potentially contains garbage data,
on the SRH ip4ip6 encapsulation.
Fixes: 32d99d0b6702 ("ipv6: sr: add support for ip4ip6 encapsulation")
Signed-off-by: Yohei Kanemaru <yohei.kanemaru@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv6/seg6_iptunnel.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/seg6_iptunnel.c b/net/ipv6/seg6_iptunnel.c index 8181ee7e1e27..ee5403cbe655 100644 --- a/net/ipv6/seg6_iptunnel.c +++ b/net/ipv6/seg6_iptunnel.c @@ -146,6 +146,8 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto) } else { ip6_flow_hdr(hdr, 0, flowlabel); hdr->hop_limit = ip6_dst_hoplimit(skb_dst(skb)); + + memset(IP6CB(skb), 0, sizeof(*IP6CB(skb))); } hdr->nexthdr = NEXTHDR_ROUTING; |