diff options
| author | Steve French <sfrench@us.ibm.com> | 2011-07-12 18:24:43 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2011-07-12 19:14:24 +0000 |
| commit | ea1be1a3c3c4b2bbc32aeb7995e18336c8060e0e (patch) | |
| tree | b9f057cb63be2fb16a48c5e1a0214dd4089d84c1 | |
| parent | 62411ab2fe5f002dff27417630ddf02cc40ca404 (diff) | |
| download | lwn-ea1be1a3c3c4b2bbc32aeb7995e18336c8060e0e.tar.gz lwn-ea1be1a3c3c4b2bbc32aeb7995e18336c8060e0e.zip | |
[CIFS] update limit for snprintf in cifs_construct_tcon
In 34c87901e113 "Shrink stack space usage in cifs_construct_tcon" we
change the size of the username name buffer from MAX_USERNAME_SIZE
(256) to 28. This call to snprintf() needs to be updated as well.
Reported by Dan Carpenter.
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
| -rw-r--r-- | fs/cifs/connect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index dbd669cc5bc7..ccc1afa0bf3b 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -3485,7 +3485,7 @@ cifs_construct_tcon(struct cifs_sb_info *cifs_sb, uid_t fsuid) goto out; } - snprintf(username, MAX_USERNAME_SIZE, "krb50x%x", fsuid); + snprintf(username, sizeof(username), "krb50x%x", fsuid); vol_info->username = username; vol_info->local_nls = cifs_sb->local_nls; vol_info->linux_uid = fsuid; |