summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@hammerspace.com>2018-11-12 16:06:51 -0500
committerTrond Myklebust <trond.myklebust@hammerspace.com>2018-11-12 16:39:13 -0500
commite3d5e573a54dabdc0f9f3cb039d799323372b251 (patch)
tree87b224d1963a39b5d064916992716cdfda49fd71
parenta652a4bc21695a57c3b8d13d222a6f8b41f100aa (diff)
downloadlwn-e3d5e573a54dabdc0f9f3cb039d799323372b251.tar.gz
lwn-e3d5e573a54dabdc0f9f3cb039d799323372b251.zip
SUNRPC: Fix a bogus get/put in generic_key_to_expire()
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
-rw-r--r--net/sunrpc/auth_generic.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
index d8831b988b1e..ab4a3be1542a 100644
--- a/net/sunrpc/auth_generic.c
+++ b/net/sunrpc/auth_generic.c
@@ -281,13 +281,7 @@ static bool generic_key_to_expire(struct rpc_cred *cred)
{
struct auth_cred *acred = &container_of(cred, struct generic_cred,
gc_base)->acred;
- bool ret;
-
- get_rpccred(cred);
- ret = test_bit(RPC_CRED_KEY_EXPIRE_SOON, &acred->ac_flags);
- put_rpccred(cred);
-
- return ret;
+ return test_bit(RPC_CRED_KEY_EXPIRE_SOON, &acred->ac_flags);
}
static const struct rpc_credops generic_credops = {