diff options
| author | Yang Yang <yang.yang29@zte.com.cn> | 2023-05-14 09:33:38 -0700 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2023-05-20 12:53:16 +0200 |
| commit | e2a1f85bf9f509afd09b5d3308e3489b65845c28 (patch) | |
| tree | 168e7aa96cf836259c6c1c5986f5d4eb995bf241 | |
| parent | a6fcdd8d95f7486150b3faadfea119fc3dfc3b74 (diff) | |
| download | lwn-e2a1f85bf9f509afd09b5d3308e3489b65845c28.tar.gz lwn-e2a1f85bf9f509afd09b5d3308e3489b65845c28.zip | |
sched/psi: Avoid resetting the min update period when it is unnecessary
Psi_group's poll_min_period is determined by the minimum window size of
psi_trigger when creating new triggers. While destroying a psi_trigger,
there is no need to reset poll_min_period if the psi_trigger being
destroyed did not have the minimum window size, since in this condition
poll_min_period will remain the same as before.
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Suren Baghdasaryan <surenb@google.com>
Link: https://lkml.kernel.org/r/20230514163338.834345-1-surenb@google.com
| -rw-r--r-- | kernel/sched/psi.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index b49af594ad28..81fca77397f6 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -1407,11 +1407,16 @@ void psi_trigger_destroy(struct psi_trigger *t) group->rtpoll_nr_triggers[t->state]--; if (!group->rtpoll_nr_triggers[t->state]) group->rtpoll_states &= ~(1 << t->state); - /* reset min update period for the remaining triggers */ - list_for_each_entry(tmp, &group->rtpoll_triggers, node) - period = min(period, div_u64(tmp->win.size, - UPDATES_PER_WINDOW)); - group->rtpoll_min_period = period; + /* + * Reset min update period for the remaining triggers + * iff the destroying trigger had the min window size. + */ + if (group->rtpoll_min_period == div_u64(t->win.size, UPDATES_PER_WINDOW)) { + list_for_each_entry(tmp, &group->rtpoll_triggers, node) + period = min(period, div_u64(tmp->win.size, + UPDATES_PER_WINDOW)); + group->rtpoll_min_period = period; + } /* Destroy rtpoll_task when the last trigger is destroyed */ if (group->rtpoll_states == 0) { group->rtpoll_until = 0; |