diff options
| author | Michael Ellerman <mpe@ellerman.id.au> | 2015-04-03 14:11:53 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-05-06 22:01:57 +0200 |
| commit | e20179f27bbe7beea759c4567d2ae8db8fb8a57a (patch) | |
| tree | 6948a59aee26aa12f5948ac5d4346456404ec1f4 | |
| parent | 0a814e8a843c9fa505c0d7fe204934b44b8c8915 (diff) | |
| download | lwn-e20179f27bbe7beea759c4567d2ae8db8fb8a57a.tar.gz lwn-e20179f27bbe7beea759c4567d2ae8db8fb8a57a.zip | |
powerpc/cell: Fix crash in iic_setup_cpu() after per_cpu changes
commit b0dd00addc5035f87ec9c5820dacc1ebc7fcb3e6 upstream.
The conversion from __get_cpu_var() to this_cpu_ptr() in iic_setup_cpu()
is wrong. It causes an oops at boot.
We need the per-cpu address of struct cpu_iic, not cpu_iic.regs->prio.
Sparse noticed this, because we pass a non-iomem pointer to out_be64(),
but we obviously don't check the sparse results often enough.
Fixes: 69111bac42f5 ("powerpc: Replace __get_cpu_var uses")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | arch/powerpc/platforms/cell/interrupt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/cell/interrupt.c b/arch/powerpc/platforms/cell/interrupt.c index 4c11421847be..3af8324c122e 100644 --- a/arch/powerpc/platforms/cell/interrupt.c +++ b/arch/powerpc/platforms/cell/interrupt.c @@ -163,7 +163,7 @@ static unsigned int iic_get_irq(void) void iic_setup_cpu(void) { - out_be64(this_cpu_ptr(&cpu_iic.regs->prio), 0xff); + out_be64(&this_cpu_ptr(&cpu_iic)->regs->prio, 0xff); } u8 iic_get_target_id(int cpu) |