diff options
| author | Namhyung Kim <namhyung@kernel.org> | 2024-11-20 16:13:34 -0800 |
|---|---|---|
| committer | Catalin Marinas <catalin.marinas@arm.com> | 2024-11-25 18:53:05 +0000 |
| commit | dfdf714fed559c09021df1d2a4bb64c0ad5f53bc (patch) | |
| tree | 98cf3ac1b81cbaccfe351ad147841aa9ea598e59 | |
| parent | 02a55f2743012a8089f09f6867220c3d57f16564 (diff) | |
| download | lwn-dfdf714fed559c09021df1d2a4bb64c0ad5f53bc.tar.gz lwn-dfdf714fed559c09021df1d2a4bb64c0ad5f53bc.zip | |
perf/arm-cmn: Ensure port and device id bits are set properly
The portid_bits and deviceid_bits were set only for XP type nodes in
the arm_cmn_discover() and it confused other nodes to find XP nodes.
Copy the both bits from the XP nodes directly when it sets up a new
node.
Fixes: e79634b53e39 ("perf/arm-cmn: Refactor node ID handling. Again.")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Will Deacon <will@kernel.org>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20241121001334.331334-1-namhyung@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
| -rw-r--r-- | drivers/perf/arm-cmn.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 49bd811c6fd6..b20fa600e510 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -2178,8 +2178,6 @@ static int arm_cmn_init_dtcs(struct arm_cmn *cmn) continue; xp = arm_cmn_node_to_xp(cmn, dn); - dn->portid_bits = xp->portid_bits; - dn->deviceid_bits = xp->deviceid_bits; dn->dtc = xp->dtc; dn->dtm = xp->dtm; if (cmn->multi_dtm) @@ -2420,6 +2418,8 @@ static int arm_cmn_discover(struct arm_cmn *cmn, unsigned int rgn_offset) } arm_cmn_init_node_info(cmn, reg & CMN_CHILD_NODE_ADDR, dn); + dn->portid_bits = xp->portid_bits; + dn->deviceid_bits = xp->deviceid_bits; switch (dn->type) { case CMN_TYPE_DTC: |