diff options
| author | Vincent Whitchurch <vincent.whitchurch@axis.com> | 2023-01-02 17:08:51 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-01-03 13:42:54 +0000 |
| commit | dfce16722b9cb842a6f23500ee80b3d07b47bdd4 (patch) | |
| tree | d1cf26bc0bdeaf479432b45f638cfcca8efa5e19 | |
| parent | 02c9e5b768b26239be7459438275f8fc835e9dc4 (diff) | |
| download | lwn-dfce16722b9cb842a6f23500ee80b3d07b47bdd4.tar.gz lwn-dfce16722b9cb842a6f23500ee80b3d07b47bdd4.zip | |
spi: pl022: Only use DT-specified DMA channels
When a platform is booted with devicetree and does not provide a
platform data structure, the driver creates one internally. enable_dma
should not be set in this structure when creating it; the probe function
will set it later if DMA channels are specified via the devicetree.
Setting enable_dma = 1 when creating this internal platform data can
lead to pl022_dma_probe() finding bogus DMA channels (since there is no
channel filter specified) when no DMA channels are specified in the
devicetree.
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Acked-by: Dhruva Gole <d-gole@ti.com>
Link: https://lore.kernel.org/r/20230102160852.3090202-1-vincent.whitchurch@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-pl022.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index e4484ace584e..a17ff839117f 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2091,7 +2091,6 @@ pl022_platform_data_dt_get(struct device *dev) return NULL; pd->bus_id = -1; - pd->enable_dma = 1; of_property_read_u32(np, "pl022,autosuspend-delay", &pd->autosuspend_delay); pd->rt = of_property_read_bool(np, "pl022,rt"); |